Skip to content

npm-check-updates: use buildNpmPackage#250875

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:npm-check-updates-buildNpmPackage
Aug 29, 2023
Merged

npm-check-updates: use buildNpmPackage#250875
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:npm-check-updates-buildNpmPackage

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Aug 23, 2023

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @flosse who originally packaged it in #4734

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Aug 23, 2023
@dotlambda dotlambda force-pushed the npm-check-updates-buildNpmPackage branch from 646e9ea to ee5b381 Compare August 23, 2023 01:49
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 23, 2023
@ofborg ofborg bot requested a review from flosse August 23, 2023 02:10
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 23, 2023
@Lord-Valen
Copy link
Contributor

Lord-Valen commented Aug 29, 2023

Better fix merge conflicts. You just had to touch nodePackages.nix... 😄

@dotlambda dotlambda force-pushed the npm-check-updates-buildNpmPackage branch from ee5b381 to 20a15c7 Compare August 29, 2023 16:01
@dotlambda dotlambda merged commit 4f00a0a into NixOS:master Aug 29, 2023
@dotlambda dotlambda deleted the npm-check-updates-buildNpmPackage branch August 29, 2023 21:34
@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flosse flosse Awaiting requested review from flosse

1 more reviewer

@Lord-Valen Lord-Valen Lord-Valen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

Repackage node2nix packages
Status: Re-packaged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dotlambda @Lord-Valen