Skip to content

Comments

Remove some unnecessary dependencies on setuptools, wheel, and poetry#250850

Merged
natsukium merged 14 commits intoNixOS:masterfrom
tjni:some-poetry-core-fixes
Aug 23, 2023
Merged

Remove some unnecessary dependencies on setuptools, wheel, and poetry#250850
natsukium merged 14 commits intoNixOS:masterfrom
tjni:some-poetry-core-fixes

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

Patch the projects owned by bachya so that they no longer declare unnecessary dependencies on setuptools, wheel, and poetry (they only need poetry-core).

Some of these projects have newer versions released, but I have refrained from updating them to keep things simple: my purpose is only to unbreak these projects after #248866 (with the exception of aiorecollect, for which my patch submitted did not merge cleanly).

In the same group as #250687 and #250819 before I realized they are related.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 22, 2023
@ofborg ofborg bot requested a review from fabaff August 22, 2023 23:08
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 22, 2023
@tjni
Copy link
Contributor Author

tjni commented Aug 22, 2023

@ofborg build python310Packages.aioguardian python311Packages.aioguardian
@ofborg build python310Packages.aionotion python311Packages.aionotion
@ofborg build python310Packages.aiopurpleair python311Packages.aiopurpleair
@ofborg build python310Packages.aiorecollect python311Packages.aiorecollect
@ofborg build python310Packages.aioridwell python311Packages.aioridwell
@ofborg build python310Packages.aiowatttime python311Packages.aiowatttime
@ofborg build python310Packages.py17track python311Packages.py17track
@ofborg build python310Packages.pyoutbreaksnearme python311Packages.pyoutbreaksnearme
@ofborg build python310Packages.pyiqvia python311Packages.pyiqvia
@ofborg build python310Packages.pyopenuv python311Packages.pyopenuv
@ofborg build python310Packages.pytile python311Packages.pytile
@ofborg build python310Packages.regenmaschine python311Packages.regenmaschine
@ofborg build python310Packages.seventeentrack python311Packages.seventeentrack
@ofborg build python310Packages.simplisafe-python python311Packages.simplisafe-python

@lelgenio
Copy link
Contributor

Result of nixpkgs-review pr 250850 run on x86_64-linux 1

68 packages built:
  • home-assistant-component-tests.guardian
  • home-assistant-component-tests.iqvia
  • home-assistant-component-tests.notion
  • home-assistant-component-tests.openuv
  • home-assistant-component-tests.purpleair
  • home-assistant-component-tests.rainmachine
  • home-assistant-component-tests.recollect_waste
  • home-assistant-component-tests.ridwell
  • home-assistant-component-tests.seventeentrack
  • home-assistant-component-tests.simplisafe
  • home-assistant-component-tests.tile
  • home-assistant-component-tests.watttime
  • python310Packages.aioguardian
  • python310Packages.aioguardian.dist
  • python310Packages.aionotion
  • python310Packages.aionotion.dist
  • python310Packages.aiopurpleair
  • python310Packages.aiopurpleair.dist
  • python310Packages.aiorecollect
  • python310Packages.aiorecollect.dist
  • python310Packages.aioridwell
  • python310Packages.aioridwell.dist
  • python310Packages.aiowatttime
  • python310Packages.aiowatttime.dist
  • python310Packages.py17track
  • python310Packages.py17track.dist
  • python310Packages.pyiqvia
  • python310Packages.pyiqvia.dist
  • python310Packages.pyopenuv
  • python310Packages.pyopenuv.dist
  • python310Packages.pyoutbreaksnearme
  • python310Packages.pyoutbreaksnearme.dist
  • python310Packages.pytile
  • python310Packages.pytile.dist
  • python310Packages.regenmaschine
  • python310Packages.regenmaschine.dist
  • python310Packages.seventeentrack
  • python310Packages.seventeentrack.dist
  • python310Packages.simplisafe-python
  • python310Packages.simplisafe-python.dist
  • python311Packages.aioguardian
  • python311Packages.aioguardian.dist
  • python311Packages.aionotion
  • python311Packages.aionotion.dist
  • python311Packages.aiopurpleair
  • python311Packages.aiopurpleair.dist
  • python311Packages.aiorecollect
  • python311Packages.aiorecollect.dist
  • python311Packages.aioridwell
  • python311Packages.aioridwell.dist
  • python311Packages.aiowatttime
  • python311Packages.aiowatttime.dist
  • python311Packages.py17track
  • python311Packages.py17track.dist
  • python311Packages.pyiqvia
  • python311Packages.pyiqvia.dist
  • python311Packages.pyopenuv
  • python311Packages.pyopenuv.dist
  • python311Packages.pyoutbreaksnearme
  • python311Packages.pyoutbreaksnearme.dist
  • python311Packages.pytile
  • python311Packages.pytile.dist
  • python311Packages.regenmaschine
  • python311Packages.regenmaschine.dist
  • python311Packages.seventeentrack
  • python311Packages.seventeentrack.dist
  • python311Packages.simplisafe-python
  • python311Packages.simplisafe-python.dist

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at all the patches, and they were perfect.
LGTM

@tjni
Copy link
Contributor Author

tjni commented Aug 23, 2023

@ofborg build python310Packages.py17track python311Packages.py17track
@ofborg build python310Packages.seventeentrack python311Packages.seventeentrack

@natsukium natsukium merged commit 5567e20 into NixOS:master Aug 23, 2023
@tjni tjni deleted the some-poetry-core-fixes branch August 23, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants