xonsh: add pip to test dependency and other changes#250801
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 23, 2023
tjni:xonsh
Merged
xonsh: add pip to test dependency and other changes#250801natsukium merged 1 commit intoNixOS:masterfrom tjni:xonsh
natsukium merged 1 commit intoNixOS:masterfrom
tjni:xonsh
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We removed
pipfrom implicitly being in the environment in #248866 andxonshhas stopped building on staging-next. This PR does the following:pipexplicitly tonativeCheckInputs. Two tests depend on this.pyprojectbuild since that's more modern and upstream uses it already.setuptoolsandwheeltonativeBuildInputs, which is what pyproject.toml asks for.sha256tohashopportunistically.LC_ALLattribute withenvto be more explicit.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)