Skip to content

makeScopeWithSplicing: fix makeScopeWithSplicing' call#250575

Merged
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:fixcall1
Aug 21, 2023
Merged

makeScopeWithSplicing: fix makeScopeWithSplicing' call#250575
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:fixcall1

Conversation

@Artturin
Copy link
Member

makeScopeWithSplicing: fix comment

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Aug 21, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 21, 2023
@Artturin Artturin merged commit 25d583b into NixOS:master Aug 21, 2023
@Artturin Artturin deleted the fixcall1 branch August 21, 2023 18:12
Copy link
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this fixes evaluating my NixOS config, thanks!

@AndersonTorres
Copy link
Member

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants