Merged
Conversation
mdarocha
approved these changes
Aug 19, 2023
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
11.by: package-maintainer
Contributor
|
Result of 2 packages built:
|
dotlambda
reviewed
Aug 25, 2023
| quake3game = throw "'quake3game' has been renamed to/replaced by 'ioquake3'"; # Converted to throw 2022-02-22 | ||
| quaternion-git = throw "quaternion-git has been removed in favor of the stable version 'quaternion'"; # Added 2020-04-09 | ||
| quilter = throw "quilter has been removed from nixpkgs, as it was unmaintained"; # Added 2021-08-03 | ||
| qutebrowser-qt6 = throw "'qutebrowser-qt6' has been replaced by 'qutebrowser', since the the qt5 version has been removed"; # Added 2023-08-19 |
Member
There was a problem hiding this comment.
Why not
Suggested change
| qutebrowser-qt6 = throw "'qutebrowser-qt6' has been replaced by 'qutebrowser', since the the qt5 version has been removed"; # Added 2023-08-19 | |
| qutebrowser-qt6 = qutebrowser; # Added 2023-08-19 |
?
Contributor
Author
There was a problem hiding this comment.
I followed other Qt applications that did a similar migration.
|
This wasn't just a version bump, you broke A massively drastic change like that shouldn't be smuggled into nixpkgs in a PR which is labeled as a version bump. Prior to this PR the expression supported both |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Version bump
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)