Skip to content

haskellPackages.binrep: unbreak#249744

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
raehik:haskell-unbreak-binrep
Sep 14, 2023
Merged

haskellPackages.binrep: unbreak#249744
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
raehik:haskell-unbreak-binrep

Conversation

@raehik
Copy link
Contributor

@raehik raehik commented Aug 17, 2023

Description of changes

Unbreak binrep package. binrep-0.5.0 is fixed, which is in 2023-08-17T12:00:00+0000 Hackage snapshot.
Latest Haskell update PR #255037 includes it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Aug 17, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 17, 2023
@raehik raehik force-pushed the haskell-unbreak-binrep branch from 0928f41 to 56b48a3 Compare August 22, 2023 15:04
@raehik raehik force-pushed the haskell-unbreak-binrep branch from 56b48a3 to af03cff Compare September 14, 2023 10:40
@raehik raehik marked this pull request as ready for review September 14, 2023 12:40
@cdepillabout
Copy link
Member

Thanks, LGTM!

@cdepillabout cdepillabout merged commit 34c08aa into NixOS:haskell-updates Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants