Introduce mapNullable into lib and use it in a few places#24974
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Apr 17, 2017
Merged
Introduce mapNullable into lib and use it in a few places#24974Ericson2314 merged 1 commit intoNixOS:masterfrom
mapNullable into lib and use it in a few places#24974Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @FRidh and @vcunat to be potential reviewers. |
Member
Author
|
Factoring out this configure flag stuff into the library I'll leave as future work. |
Also simply some configure flag logic my grep also alerted me too.
Ericson2314
force-pushed
the
mapNullable
branch
from
828203f to
85aa500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also simply some configure flag logic my grep also alerted me too.
Motivation for this change
Cleanliness.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)