Skip to content

python3: 3.10 -> 3.11#249731

Closed
mweinelt wants to merge 1 commit intoNixOS:stagingfrom
mweinelt:python311-default
Closed

python3: 3.10 -> 3.11#249731
mweinelt wants to merge 1 commit intoNixOS:stagingfrom
mweinelt:python311-default

Conversation

@mweinelt
Copy link
Member

Updates the default python version to 3.11, while keeping 3.10 around until after the NixOS 23.11 release.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Updates the default python version to 3.11, while keeping 3.10 around
until after the NixOS 23.11 release.
@mweinelt mweinelt requested a review from FRidh as a code owner August 17, 2023 12:11
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 17, 2023
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Aug 17, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 17, 2023
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because, why not?

@NickCao
Copy link
Member

NickCao commented Aug 18, 2023

Shall we also update doc/languages-frameworks/python.section.md and the release note?

@raboof
Copy link
Member

raboof commented Aug 25, 2023

Shall we also update doc/languages-frameworks/python.section.md and the release note?

I've created a commit proposing those updates in 4b0b9d0 . I expect there will be some review comments / iteration on getting this 'just right'.

I would propose we merge this PR as-is so we can start ironing out any bugs with python 3.11 ASAP, and iterate on the messaging in parallel.

@mweinelt
Copy link
Member Author

This should go through python-updates, so we can inspect and iterate on the fallout before it hits staging.

cc @tjni do you want to drive this?

@tjni
Copy link
Contributor

tjni commented Aug 25, 2023

Sure thing!

@tjni
Copy link
Contributor

tjni commented Aug 27, 2023

I have been working on addressing some fallout from #248866, but I'll start working on this tomorrow.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Sep 6, 2023
@mweinelt
Copy link
Member Author

Continues on python-updates.

@mweinelt mweinelt closed this Sep 12, 2023
@mweinelt mweinelt deleted the python311-default branch September 12, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

Development

Successfully merging this pull request may close these issues.

7 participants

Comments