Closed
Conversation
Updates the default python version to 3.11, while keeping 3.10 around until after the NixOS 23.11 release.
Member
|
Shall we also update |
lukegb
approved these changes
Aug 18, 2023
Member
I've created a commit proposing those updates in 4b0b9d0 . I expect there will be some review comments / iteration on getting this 'just right'. I would propose we merge this PR as-is so we can start ironing out any bugs with python 3.11 ASAP, and iterate on the messaging in parallel. |
Member
Author
|
This should go through python-updates, so we can inspect and iterate on the fallout before it hits staging. cc @tjni do you want to drive this? |
Contributor
|
Sure thing! |
Contributor
|
I have been working on addressing some fallout from #248866, but I'll start working on this tomorrow. |
Member
Author
|
Continues on python-updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the default python version to 3.11, while keeping 3.10 around until after the NixOS 23.11 release.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)