Skip to content

Comments

python310Packages.qbittorrent-api: init at 2023.7.52#249164

Merged
natsukium merged 1 commit intoNixOS:masterfrom
savyajha:add-qbittorrentapi
Aug 17, 2023
Merged

python310Packages.qbittorrent-api: init at 2023.7.52#249164
natsukium merged 1 commit intoNixOS:masterfrom
savyajha:add-qbittorrentapi

Conversation

@savyajha
Copy link
Contributor

Description of changes

Adds the qbittorrent-api package, which is a python API client for qbittorrent.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 14, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 14, 2023
@onny
Copy link
Contributor

onny commented Aug 15, 2023

Please change PR and commit title to python310packages.qbittorrent-api: init at 2023.7.52

Comment on lines 28 to 32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [
setuptools
];
nativeBuildInputs = [
setuptools
wheel
];

We will have to add wheel to nativeBuildInputs.
see #245509

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelog = "https://github.com/rmartin16/qbittorrent-api/blob/main/CHANGELOG.md";
changelog = "https://github.com/rmartin16/qbittorrent-api/blob/v${version}/CHANGELOG.md";

@savyajha savyajha force-pushed the add-qbittorrentapi branch from 262c863 to 40c1d2b Compare August 15, 2023 11:16
@savyajha savyajha changed the title python310Packages.qbittorrent-api: init python310Packages.qbittorrent-api: init at 2023.7.52 Aug 15, 2023
@savyajha
Copy link
Contributor Author

Made the requested changes.

@savyajha savyajha force-pushed the add-qbittorrentapi branch from 40c1d2b to 22df187 Compare August 15, 2023 13:11
@savyajha savyajha force-pushed the add-qbittorrentapi branch from 22df187 to 2e980b4 Compare August 16, 2023 07:46
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@natsukium natsukium merged commit c4fa270 into NixOS:master Aug 17, 2023
@savyajha savyajha deleted the add-qbittorrentapi branch August 17, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants