python310Packages.qbittorrent-api: init at 2023.7.52#249164
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 17, 2023
Merged
python310Packages.qbittorrent-api: init at 2023.7.52#249164natsukium merged 1 commit intoNixOS:masterfrom
natsukium merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
|
Please change PR and commit title to |
natsukium
reviewed
Aug 15, 2023
Comment on lines
28
to
32
Member
There was a problem hiding this comment.
Suggested change
| buildInputs = [ | |
| setuptools | |
| ]; | |
| nativeBuildInputs = [ | |
| setuptools | |
| wheel | |
| ]; |
We will have to add wheel to nativeBuildInputs.
see #245509
Member
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/rmartin16/qbittorrent-api/blob/main/CHANGELOG.md"; | |
| changelog = "https://github.com/rmartin16/qbittorrent-api/blob/v${version}/CHANGELOG.md"; |
262c863 to
40c1d2b
Compare
Contributor
Author
|
Made the requested changes. |
40c1d2b to
22df187
Compare
natsukium
reviewed
Aug 16, 2023
22df187 to
2e980b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the qbittorrent-api package, which is a python API client for qbittorrent.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)