python3Packages.pillow & python3Packages.pillow-simd: Fix cross compilation#249136
python3Packages.pillow & python3Packages.pillow-simd: Fix cross compilation#2491362 commits merged intoNixOS:masterfrom
Conversation
Fixes the build time error: `ModuleNotFoundError: No module named 'setuptools'`.
|
The hook should make setuptools available, even when cross-compiling. |
|
From what I can see it only gets added if using |
ghost
left a comment
There was a problem hiding this comment.
Fixed pkgsCross.*.python3Packages.pillow for me.
|
This causes over 13k rebuilds in total. Why merge directly to master? |
|
Don't the docs say that small changes go to master? Or did I miss something? I just saw that the CONTRIBUTING.md file got recently expanded from the time I created this PR, maybe I just missed something new there, I'll go re-read it. Sorry! EDIT: Yes, I just saw the new flow of merged pull requests section about branches. Again, SORRY! |
|
The automatic red |
|
Reapplied in 094bfcf |
Fixes the build time error:
ModuleNotFoundError: No module named 'setuptools'.Description of changes
Added
setuptoolsonnativeBuildInputs, so that it's available at build time when cross compiling.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)