Skip to content

Change types.string error to a warning instead #248278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
infinisil merged 2 commits into from
Aug 10, 2023
Merged

Change types.string error to a warning instead #248278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
040b0ad
Revert "lib.types.string: Deprecation error instead of warning"
infinisil Aug 10, 2023
5075a51
lib.types.string: Use lib.warn instead of deprecationMessage
infinisil Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/types.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,12 @@ rec {

# Deprecated; should not be used because it quietly concatenates
# strings, which is usually not what you want.
string = throw "The type `types.string` is deprecated. See https://github.com/NixOS/nixpkgs/pull/66346 for better alternative types.";
# We use a lib.warn because `deprecationMessage` doesn't trigger in nested types such as `attrsOf string`
string = lib.warn
"The type `types.string` is deprecated. See https://github.com/NixOS/nixpkgs/pull/66346 for better alternative types."
(separatedString "" // {
name = "string";
});

passwdEntry = entryType: addCheck entryType (str: !(hasInfix ":" str || hasInfix "\n" str)) // {
name = "passwdEntry ${entryType.name}";
Expand Down