Conversation
|
@pajowu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
|
I have also been using this very useful chrome extension in my own nixos configuration, but hadn't packaged it up as a module like in this pull request. If it's useful, see these as well: @pajowu Instead of using the prebuilt binary from upstream, I'd recommend using |
|
@danielfullmer that looks great, i'll try to change it to build from git. That way it would also support 32bit |
Precompiled version only supports linux64, git version should also support darwin
|
Why not just https://github.com/nwallace/passff? :) |
|
|
||
| buildGoPackage rec { | ||
| name = "browserpass-unstable-${version}"; | ||
| version = "HEAD"; |
There was a problem hiding this comment.
Use proper way to name pkg. In this case it should be browserpass-(date of commit). Also please use sha for consistency.
passff also needs a native extension, which would need a similar install method. Also giving more options seems like a good thing |
Motivation for this change
The browser-extension for pass (browserpass) needs a native component. That component is installed using this package. The Config-files are added to chrome and chromium with the
programs.browserpassmodule.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)