Skip to content

browserpass: init at 1.0.2#24803

Merged
7c6f434c merged 5 commits intoNixOS:masterfrom
pajowu:master
May 1, 2017
Merged

browserpass: init at 1.0.2#24803
7c6f434c merged 5 commits intoNixOS:masterfrom
pajowu:master

Conversation

@pajowu
Copy link
Contributor

@pajowu pajowu commented Apr 10, 2017

Motivation for this change

The browser-extension for pass (browserpass) needs a native component. That component is installed using this package. The Config-files are added to chrome and chromium with the programs.browserpass module.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@pajowu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers.

@danielfullmer
Copy link
Contributor

I have also been using this very useful chrome extension in my own nixos configuration, but hadn't packaged it up as a module like in this pull request. If it's useful, see these as well:
https://github.com/danielfullmer/nixrc/blob/master/pkgs/browserpass/default.nix
and
https://github.com/danielfullmer/nixrc/blob/master/profiles/desktop/default.nix#L197

@pajowu Instead of using the prebuilt binary from upstream, I'd recommend using buildGoPackage against the source code.

@pajowu
Copy link
Contributor Author

pajowu commented Apr 10, 2017

@danielfullmer that looks great, i'll try to change it to build from git. That way it would also support 32bit

Precompiled version only supports linux64, git version should also support darwin
@jagajaga
Copy link
Member


buildGoPackage rec {
name = "browserpass-unstable-${version}";
version = "HEAD";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use proper way to name pkg. In this case it should be browserpass-(date of commit). Also please use sha for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with 11913f2

@pajowu
Copy link
Contributor Author

pajowu commented Apr 12, 2017

@jagajaga

Why not just https://github.com/nwallace/passff? :)

passff also needs a native extension, which would need a similar install method. Also giving more options seems like a good thing

@7c6f434c 7c6f434c merged commit 4d2f7b6 into NixOS:master May 1, 2017
@wucke13
Copy link
Contributor

wucke13 commented Oct 17, 2017

@ttuegel @pajowu
This is still not resolved, browserpass does not work for me on the most recent firefox package in NixOS 17.09

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants