Merged
Conversation
cafkafk
reviewed
Aug 7, 2023
ofborg
bot
added
8.has: package (new)
|
Hey, I'm the upstream maintainer; I'm just curious when this is going to finally end up in |
Member
someone with commit bit needs to take a look at it, or someone without needs to bring it to their attention by e.g. asking on matrix |
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
Member
|
If you are still interested in this PR, please rebase and update to 0.1.3. Otherwise feel free to close it. |
|
Hello, I'm a little rusty; can I ask who needs to rebase and update?
…On Thu, Feb 6, 2025 at 4:58 AM Donovan Glover ***@***.***> wrote:
If you are still interested in this PR, please rebase and update to 0.1.3.
Otherwise feel free to close it.
—
Reply to this email directly, view it on GitHub
<#247799 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADVLRIQRZRNVCHFDBY65WD2OM555AVCNFSM6AAAAABWTHVSTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZZGQ4TENZQGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Member
|
@evils does. If so we can continue the process of adding |
ofborg
bot
removed
the
2.status: merge conflict
github-actions
bot
added
10.rebuild-darwin: 1
Member
donovanglover
left a comment
donovanglover
left a comment
There was a problem hiding this comment.
Tested and works just a quick review to align the package with modern standards.
Co-authored-by: Donovan Glover <donovan@dglover.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
packaged it to give it a go, seems like it may be of use to someone
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)