RFC: python: use openssl without legacy configuration #247754
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Our internal Hydra builds of Nixpkgs have not noticed any additional breakage from removing the legacy module the OpenSSL used by Python.
On the flip side, we have encountered Segfaults which seem similar to openssl/openssl#18049. We've found that removing the legacy module has resolved these issues. (Using OpenSSL 3.0.9, specifically.)
All the same, this is a "big" change that may have unforeseen consequences. For prior art, there is a discussion here where some have also gone the route of OpenSSL 3 + no legacy module.
I'd love to start the discussion on this and see if Nixpkgs is ready for this change.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)