Skip to content

lib.systems: add qemu's funky custom name for mips n32#247288

Merged
Artturin merged 1 commit intomasterfrom
unknown repository
Sep 21, 2023
Merged

lib.systems: add qemu's funky custom name for mips n32#247288
Artturin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 5, 2023

Description of changes

Qemu's name for mips64[el] using the n32 ABI is "mipsn32[el]". That's the first time I've seen that name for it. Oh well.

Necessary in order to build p11-kit via #245124.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Aug 5, 2023
Qemu's name for mips64[el] using the n32 ABI is "mipsn32[el]".
That's the first time I've seen that name for it.  Oh well.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 5, 2023
@ghost ghost marked this pull request as ready for review August 5, 2023 07:56
@ghost ghost requested review from Ericson2314, alyssais and matthewbauer as code owners August 5, 2023 07:56
@Artturin Artturin merged commit aeaa0a7 into NixOS:master Sep 21, 2023
@ghost ghost deleted the pr/lib/systems/qemu-mips64n32 branch January 23, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant