python3.pkgs.cmake: init stub at 3.26.4#247064
Merged
tjni merged 3 commits intoNixOS:stagingfrom Aug 16, 2023
tjni:cmake
Merged
python3.pkgs.cmake: init stub at 3.26.4#247064tjni merged 3 commits intoNixOS:stagingfrom tjni:cmake
tjni merged 3 commits intoNixOS:stagingfrom
tjni:cmake
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
Contributor
Author
|
|
This was referenced Aug 4, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2509 |
SuperSandro2000
approved these changes
Aug 8, 2023
figsoda
added
the
12.approvals: 1
I would like this to be as transparent as possible for Python packages, so I'm shadowing the top-level cmake attribute by using the same name as the PyPI package that this replaces.
Since this project uses scikit-build-core and does not declare its own build dependency on the cmake PyPI module, it can depend on the tool by itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I would like this to be as transparent as possible for Python packages, so I'm shadowing the top-level cmake attribute by using the same name as the PyPI package that this replaces.
As in #246963, a goal is to help with the rollout of #245509 by letting packages that depend on this in their builds to pass dependency validation.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)