Skip to content

file: 5.44 -> 5.45#247040

Merged
2 commits merged intoNixOS:stagingfrom
trofi:file-update
Aug 16, 2023
Merged

file: 5.44 -> 5.45#247040
2 commits merged intoNixOS:stagingfrom
trofi:file-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Aug 3, 2023 •
edited
Loading

Changes: file/file@FILE5_44...FILE5_45

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@trofi trofi marked this pull request as draft August 3, 2023 22:23
@trofi
Copy link
Contributor Author

trofi commented Aug 3, 2023

Fails some tests. Needs a bit more investigation.

@trofi
Copy link
Contributor Author

trofi commented Aug 3, 2023 •
edited
Loading

pkgsi686Linux.file fails some date comparison tests. Probably fixed by file/file@218fdf8

@trofi
Copy link
Contributor Author

trofi commented Aug 3, 2023

Fixed i686 tests. Ready for review.

@trofi trofi marked this pull request as ready for review August 3, 2023 23:06
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Aug 4, 2023
@ofborg ofborg bot requested a review from doronbehar August 4, 2023 00:12
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 4, 2023
doronbehar
doronbehar requested changes Aug 4, 2023
View reviewed changes
@ofborg ofborg bot requested a review from doronbehar August 4, 2023 17:45
ghost
ghost reviewed Aug 5, 2023
View reviewed changes
@trofi
Update pkgs/tools/misc/file/default.nix
f0c74d4 
Co-authored-by: Adam Joseph <54836058+amjoseph-nixpkgs@users.noreply.github.com>
@ghost
Copy link

ghost commented Aug 14, 2023

@ofborg eval

@ofborg ofborg bot requested a review from doronbehar August 14, 2023 12:59
@ghost ghost merged commit ffe4cde into NixOS:staging Aug 16, 2023
@trofi trofi deleted the file-update branch August 16, 2023 06:44
@trofi
Copy link
Contributor Author

trofi commented Aug 20, 2023

python3Packages.python-magic testsuite regressed. Proposed #250362 to fix it.

This was referenced Aug 27, 2023
Merged
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @doronbehar