ankisyncd-rs: allow specifying initial username and password#246266
Open
anpandey wants to merge 1 commit intoNixOS:masterfrom
Open
ankisyncd-rs: allow specifying initial username and password#246266anpandey wants to merge 1 commit intoNixOS:masterfrom
anpandey wants to merge 1 commit intoNixOS:masterfrom
Conversation
anki-sync-server-rs exposes the ANKISYNCD_USERNAME and ANKISYNCD_PASSWORD env variables for initializing the auth db with a username and a password, which this exposes to make the config more reproducible for a single-user use case.
martinetd
approved these changes
May 10, 2024
Member
martinetd
left a comment
There was a problem hiding this comment.
oh, this module doesn't define meta.maintainers so I never got pinged (and the folks who created it ages before me neither)
ankisyncd-rs is officially no longer maintained so the ankisyncd module have been deprecated and will be removed in master after 2405 is released (in 3 weeks, replaced by #257692 ), so this is probably no longer really worth merging, but sure why not - it might make sense to merge for the 24.05 branch if it's helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anki-sync-server-rs exposes the ANKISYNCD_USERNAME and ANKISYNCD_PASSWORD env variables for initializing the auth db with a username and a password, which this exposes to make the config more reproducible for a single-user use case.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)