Skip to content

linux.configfile: remove unused kernelTarget attr#245965

Merged
Artturin merged 1 commit intostagingfrom
unknown repository
Sep 30, 2023
Merged

linux.configfile: remove unused kernelTarget attr#245965
Artturin merged 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 28, 2023

This reapplies #234090 after the revert of #221707 in #245449.

Description of changes

As far as I can tell this is unused since f95d214.

Fixes: f95d214 ("Implement generic kernel build via manual-config")
Fixes: #234084

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

As far as I can tell this is unused since f95d214.

Fixes: f95d214 ("Implement generic kernel build via manual-config")
Fixes: #234084
@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Jul 28, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 28, 2023
@Artturin Artturin merged commit 425ddf1 into NixOS:staging Sep 30, 2023
@ghost ghost deleted the pr/linux/kernel/repick2 branch January 23, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants