Skip to content

karma: use buildNpmPackage, 0.114 -> 0.115#245953

Merged
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:karma-buildNpmPackage
Jul 31, 2023
Merged

karma: use buildNpmPackage, 0.114 -> 0.115#245953
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:karma-buildNpmPackage

Conversation

@dotlambda
Copy link
Member

Description of changes

See #229475.

Diff: prymitive/karma@v0.114...v0.115

Changelog: https://github.com/prymitive/karma/blob/v0.115/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @NukaDuka

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 28, 2023
@dotlambda dotlambda force-pushed the karma-buildNpmPackage branch from 6dec876 to e75a8ae Compare July 31, 2023 15:41
@dotlambda dotlambda requested a review from NukaDuka July 31, 2023 15:42
Copy link
Contributor

@NukaDuka NukaDuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dotlambda dotlambda merged commit bfab60e into NixOS:master Jul 31, 2023
@dotlambda dotlambda deleted the karma-buildNpmPackage branch July 31, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

Status: Re-packaged

Development

Successfully merging this pull request may close these issues.

2 participants