lomiri.lomiri-download-manager: init at 0.1.2#245900
Merged
pbsds merged 2 commits intoNixOS:masterfrom Dec 18, 2023
Merged
Conversation
ofborg
bot
added
8.has: package (new)
This was referenced Oct 20, 2023
OPNA2608
force-pushed
the
init/lomiri/lomiri-download-manager
branch
2 times, most recently
from
5d04ad4 to
c467dc6
Compare
pbsds
added
the
2.status: merge conflict
OPNA2608
force-pushed
the
init/lomiri/lomiri-download-manager
branch
from
c467dc6 to
da77b9f
Compare
OPNA2608
removed
the
2.status: merge conflict
OPNA2608
force-pushed
the
init/lomiri/lomiri-download-manager
branch
3 times, most recently
from
43e4543 to
0a715ab
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3107 |
SuperSandro2000
approved these changes
Dec 16, 2023
OPNA2608
force-pushed
the
init/lomiri/lomiri-download-manager
branch
from
0a715ab to
f5b984c
Compare
Contributor
Author
|
Rebased to resolve merge conflict. |
pbsds
approved these changes
Dec 18, 2023
Member
pbsds
left a comment
pbsds
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 245900 run on x86_64-linux 1
3 packages built:
- lomiri.lomiri-download-manager
- lomiri.lomiri-download-manager.dev
- lomiri.lomiri-download-manager.doc
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
- executables tested on x86_64-linux
env -i lddis happy, daemons run and the strace looks sane, didn't test with any client application
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - build time only dependencies are declared in
nativeBuildInputs- unsure about cmake-extras
- source is fetched using the appropriate function
- the list of
phasesis not overridden - when a phase (like
installPhase) is overridden it starts withrunHook preInstalland ends withrunHook postInstall. - patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- patches that are remotely available are fetched rather than vendored
Sorry to hit you with comment nits.
Note to self: CI is all green
| hash = "sha256-UztcBAAFXDX2j0X5D3kMp9q0vFm3/PblUAKPJ5nZyiY="; | ||
| }) | ||
|
|
||
| # Make documentation building optional |
Member
There was a problem hiding this comment.
Suggested change
| # Make documentation building optional |
Looks like a copy-paste error, and name clearly explains what the patch does anyway.
Contributor
Author
There was a problem hiding this comment.
Copy-pasting mistake yeah, will fix.
Edit:
and
nameclearly explains what the patch does anyway
Do you want me to remove this from all of the fetchpatches?
pkgs/desktops/lomiri/services/lomiri-download-manager/default.nix
Outdated
Show resolved
Hide resolved
Lainera
pushed a commit
to Lainera/nixpkgs
that referenced
this pull request
Dec 20, 2023
squashed from NixOS#245900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
Lomiri Download Manager, a daemon for performing long-running downloads in the background. Required by Content Hub and Lomiri itself.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)