Skip to content

libgudev: fix cross failing to build checks #245761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lilyinstarlight wants to merge 1 commit into from
Closed

libgudev: fix cross failing to build checks #245761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkgs/development/libraries/libgudev/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
, gnome
, vala
, gobject-introspection
, fetchpatch
, glibcLocales
, umockdev
}:
Expand Down Expand Up @@ -46,6 +45,10 @@ stdenv.mkDerivation (finalAttrs: {
umockdev
];

mesonFlags = [
(lib.mesonEnable "tests" finalAttrs.finalPackage.doCheck)
Copy link
Member

@jtojnar jtojnar Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just finalAttrs.doCheck?

Copy link
Member Author

@lilyinstarlight lilyinstarlight Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, finalAttrs.doCheck was still true and so didn't work, and I didn't look into it further 🤷🏻‍♀️

Copy link
Member Author

@lilyinstarlight lilyinstarlight Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's because until it goes through mkDerivation, the doCheck attr still hasn't been transformed. It looks like finalAttrs is resolved after all overrides, but finalPackage is after the mkDerivationSimple transformations

];

doCheck = true;

passthru = {
Expand Down