Add services for Bitcoin, Dash, Parity and Monero#24576
Add services for Bitcoin, Dash, Parity and Monero#24576MDeltaX wants to merge 6 commits intoNixOS:masterfrom
Conversation
|
@koenigmaximilian, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @joachifm and @offlinehacker to be potential reviewers. |
| default = defaultUser; | ||
| description = userDescription; | ||
| type = types.str; | ||
| }; |
There was a problem hiding this comment.
since static user/group names are allocated, it is not really configurable. I would just drop these two options here and in every other service.
There was a problem hiding this comment.
I don't really get what you mean. You can set user with services.bitcoind.user or services.dashd.user
Static is only the default value.
| description = opts.user.description; | ||
| home = cfg.dataDir; | ||
| createHome = true; | ||
| }); |
There was a problem hiding this comment.
Does this really requires a home in "/home"? Usually system user a created in /var/lib/. This directory can be created on service start.
There was a problem hiding this comment.
It sets cfg.dataDir as home directory (not /home)
parity/ethash requires a valid home dir: https://github.com/paritytech/parity/blob/8404edb656693270ec1cd3956d204f625d28ec7c/ethash/src/compute.rs#L109
There was a problem hiding this comment.
And the reason I chose the data directory and not a path in /var/lib is that I'm used to have the data dir on an encrypted partition and don't want information to be leaked by ethash
|
This PR still seems relevant. Is there motivation to make this up-to-date with master? |
|
@MDeltaX please rebase or close the PR |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Please feel free to reopen or start a new PR if there is any interest. |
8 participants
Requires #24396