WIP: python3Packages.torch: migrate to setupCudaHook#245516
Closed
SomeoneSerge wants to merge 3 commits intoNixOS:masterfrom
Closed
WIP: python3Packages.torch: migrate to setupCudaHook#245516SomeoneSerge wants to merge 3 commits intoNixOS:masterfrom
SomeoneSerge wants to merge 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
SomeoneSerge
commented
Jul 26, 2023
| # confirm that cudatoolkits are sync'd across dependencies | ||
| assert !(MPISupport && cudaSupport) || mpi.cudatoolkit == cudatoolkit; | ||
| assert !cudaSupport || magma.cudaPackages.cudatoolkit == cudatoolkit; | ||
| with cudaPackages; |
Contributor
Author
There was a problem hiding this comment.
I probably shouldn't use with
Member
There was a problem hiding this comment.
At least not with that big of a scope.
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
Result of 24 packages marked as broken and skipped:
174 packages failed to build:
246 packages built:
|
Contributor
Author
Failed derivationsDetails
|
Member
|
I think a lot of these are new failures on master due to |
Contributor
Author
|
RE: torchvision Unbelievavble. This actually resulted in a WITH_CUDA=OFF build. The setup py even seems to ignore USE_CUDA=1. We really should invoke cmake directly |
Contributor
Author
This silently resets use_cuda to false. There's a bunch of other occasions where pytorch does that. The behaviour we'd like whenwe've set with_cuda but a dependency is missing is immediate failure |
SomeoneSerge
changed the title
Contributor
Author
|
Looking at the logs, this torch revision seems to ignore cmake_cudatoolkit_root. Maybe the release is still using the legacy findcuda. I guess I'll just come back to this in 2 weeks |
Contributor
Author
|
Superseded by the much more thorough implementation in #249259! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)