expand-response-params: explain what a "response file" is#245297
Conversation
I hadn't heard of this term before, so I assume other people might not have either. This commit adds a comment to expand-response-params explaining what a "response file" is. Most mentions of "response file" in Nixpkgs are near some kind of reference to this derivation, so anybody trying to figure out what this is will encounter this comment pretty quickly.
ghost
mentioned this pull request
12 tasks
ofborg
bot
added
10.rebuild-darwin: 0
ghost
closed this
ghost
deleted the
Member
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I hadn't heard of this term before, so I assume other people might not have either. This commit adds a comment to expand-response-params explaining what a "response file" is.
Most mentions of "response file" in Nixpkgs are near some kind of reference to this derivation, so anybody trying to figure out what
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)this is will encounter this comment pretty quickly.