python3Packages.tpm2-pytss: fixup build#245139
Merged
peterhoeg merged 1 commit intoNixOS:masterfrom Jul 27, 2023
Merged
Conversation
Member
|
How about using |
Member
Author
|
That also works, but I don't know if that's worth it. |
Member
|
That makes perfect sense. I suggest adding that in as a comment above the patch entry to make it clear for anyone looking at this in the future. |
3575d76 to
b0bf69d
Compare
This fixes the build that broke after the upgrade of tpm2-tss to 4.0.1 Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
b0bf69d to
9af0813
Compare
Member
|
@GrahamcOfBorg build python3Packages.tpm2-pytss |
rhysmdnz
approved these changes
Jul 27, 2023
Contributor
|
Result of 7 packages built:
|
Member
|
I've been running with this for a few days and it works great. |
12 tasks
RaitoBezarius
pushed a commit
to baloo/nixpkgs
that referenced
this pull request
Sep 1, 2023
Hardening got enabled in NixOS#246244 in a way that makes it difficult to disable for projects to disable selectively. The fix used in NixOS#245139 (and provided upstream) no longer works, and we need to disable hardening entirely to make `pycparser` which is unable to handle fortify bits. Fixes NixOS#252023. Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes the build that broke after the upgrade of tpm2-tss to 4.0.1
Fixes #244107
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)