Skip to content

ubootOdroidN2: init#245100

Open
oddlama wants to merge 2 commits intoNixOS:masterfrom
oddlama:feat-odroid-n2
Open

ubootOdroidN2: init#245100
oddlama wants to merge 2 commits intoNixOS:masterfrom
oddlama:feat-odroid-n2

Conversation

@oddlama
Copy link
Copy Markdown
Member

@oddlama oddlama commented Jul 23, 2023 •
edited
Loading

Description of changes

Adds a u-boot build for the N2 and N2+.
Requires proprietary blobs from https://github.com/LibreELEC/amlogic-boot-fi
U-boot wiki for the boards: https://u-boot.readthedocs.io/en/latest/board/amlogic/odroid-n2.html

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 24, 2023
@oddlama oddlama requested a review from samueldr July 24, 2023 18:50
samueldr
samueldr reviewed Jul 24, 2023
View reviewed changes
@oddlama
Copy link
Copy Markdown
Member Author

oddlama commented Jul 25, 2023

Added meson64-tools package and updated the uboot builder to utilize it.

samueldr
samueldr reviewed Jul 26, 2023
View reviewed changes
samueldr
samueldr reviewed Jul 26, 2023
View reviewed changes
@oddlama
Copy link
Copy Markdown
Member Author

oddlama commented Jul 26, 2023

Thanks! Changed package description and tooling binary output names as suggested.

@oddlama oddlama force-pushed the feat-odroid-n2 branch 2 times, most recently from 5bf4de6 to ecd0a9b Compare July 27, 2023 19:53
@oddlama
Copy link
Copy Markdown
Member Author

oddlama commented Jul 27, 2023

Rebased on master and removed unnecessary dependency yacc which is included in bison.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 27, 2023
@ofborg ofborg bot requested review from dezgeg, lopsided98 and samueldr July 27, 2023 20:11
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 27, 2023
erdnaxe
erdnaxe approved these changes Aug 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@erdnaxe erdnaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 245100 run on x86_64-linux 1

1 package built:
  • meson64-tools

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Sep 1, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1084

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 6, 2023
sorki
sorki reviewed Oct 20, 2023
View reviewed changes
pkgs/misc/uboot/default.nix Outdated
Copy link
Copy Markdown
Member

@sorki sorki Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have an expression for building SD image which uses this, you can put these into sdImage.postBuildCommands, check out https://github.com/novena-next/nixos-novena/blob/master/configuration.nix#L62-L64

The comment is fine of course, it's just something you might find interesting. 😄

sorki
sorki approved these changes Oct 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorki sorki mentioned this pull request Oct 20, 2023
Closed
12 tasks
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 8, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 26, 2024
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Oct 29, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 29, 2024
@oddlama
Copy link
Copy Markdown
Member Author

oddlama commented Nov 21, 2024

changes: formatted with nixpkgs-rfc-style

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 22, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@nixpkgs-ci nixpkgs-ci bot added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueldr samueldr Awaiting requested review from samueldr

@dezgeg dezgeg Awaiting requested review from dezgeg

@lopsided98 lopsided98 Awaiting requested review from lopsided98

3 more reviewers

@angerman angerman angerman left review comments

@sorki sorki sorki approved these changes

@erdnaxe erdnaxe erdnaxe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@oddlama @nixos-discourse @angerman @sorki @samueldr @erdnaxe @wegank