Skip to content

various packages: pin boost179#244831

Closed
tobim wants to merge 1 commit intoNixOS:staging-nextfrom
tobim:pkgs/pin-boost179
Closed

various packages: pin boost179#244831
tobim wants to merge 1 commit intoNixOS:staging-nextfrom
tobim:pkgs/pin-boost179

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Jul 22, 2023

Description of changes

#244111 (comment)

Pin boost to boost179 for packages currently failing in staging-next.

@tobim tobim requested review from RaghavSood and mmahut as code owners July 22, 2023 13:12
@vcunat
Copy link
Member

vcunat commented Jul 22, 2023

As OfBorg noticed, miopen won't evaluate

pkgs/development/libraries/miopen/default.nix:1:1 called with unexpected argument 'boost'

@vcunat
Copy link
Member

vcunat commented Jul 22, 2023

By the way, I generally expected to do these overrides inside the callPackage invocations, but perhaps it is better the way you did.

@vcunat
Copy link
Member

vcunat commented Jul 22, 2023

opendungeons is still failing to build for me

/build/source/source/modes/MenuModeEditorNew.cpp: In member function 'bool MenuModeEditorNew::launchSelectedButtonPressed(const CEGUI::EventArgs&)':
/build/source/source/modes/MenuModeEditorNew.cpp:138:37: error: 'std::string boost::filesystem::extension(const path&)' is deprecated: Use path::extension() instead [-Werror=deprecated-declarations]
  138 |     if (boost::filesystem::extension(level) != ".level") {
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
In file included from include/boost/filesystem.hpp:21,
                 from /build/source/source/modes/MenuModeEditorNew.cpp:36:
include/boost/filesystem/convenience.hpp:29:20: note: declared here

@vcunat
Copy link
Member

vcunat commented Jul 22, 2023

I confirm that all the others were failing on Hydra and built for me now. (all my tests are x86_64 NixOS)

vcunat pushed a commit that referenced this pull request Jul 22, 2023
Taken from PR #244831 and vcunat amended the miopen override.
@vcunat
Copy link
Member

vcunat commented Jul 22, 2023

Thanks. So to clean up the newly-failing list on Hydra, I pushed a commit where I fixed and tested the miopen* builds and omitted the opendungeons change for now.

@tobim
Copy link
Contributor Author

tobim commented Jul 24, 2023

Integrated as ba2ce6e.

@tobim tobim closed this Jul 24, 2023
@tobim tobim deleted the pkgs/pin-boost179 branch July 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants