Skip to content

Comments

python310Packages.opentelemetry-api: relax importlib-metadata constraint#244792

Merged
marsam merged 1 commit intoNixOS:staging-nextfrom
tjni:opentelemetry-api
Jul 22, 2023
Merged

python310Packages.opentelemetry-api: relax importlib-metadata constraint#244792
marsam merged 1 commit intoNixOS:staging-nextfrom
tjni:opentelemetry-api

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Jul 22, 2023

Things done

Needed by #244111.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 22, 2023
@ofborg ofborg bot requested a review from limeytexan July 22, 2023 08:43
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 22, 2023
@natsukium
Copy link
Member

Result of nixpkgs-review pr 244792 run on x86_64-linux 1

56 packages built:
  • python310Packages.opentelemetry-api
  • python310Packages.opentelemetry-api.dist
  • python310Packages.opentelemetry-exporter-otlp
  • python310Packages.opentelemetry-exporter-otlp-proto-common
  • python310Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python310Packages.opentelemetry-exporter-otlp-proto-grpc
  • python310Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python310Packages.opentelemetry-exporter-otlp-proto-http
  • python310Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python310Packages.opentelemetry-exporter-otlp.dist
  • python310Packages.opentelemetry-exporter-prometheus
  • python310Packages.opentelemetry-exporter-prometheus.dist
  • python310Packages.opentelemetry-instrumentation
  • python310Packages.opentelemetry-instrumentation-asgi
  • python310Packages.opentelemetry-instrumentation-asgi.dist
  • python310Packages.opentelemetry-instrumentation-django
  • python310Packages.opentelemetry-instrumentation-django.dist
  • python310Packages.opentelemetry-instrumentation-wsgi
  • python310Packages.opentelemetry-instrumentation-wsgi.dist
  • python310Packages.opentelemetry-instrumentation.dist
  • python310Packages.opentelemetry-sdk
  • python310Packages.opentelemetry-sdk.dist
  • python310Packages.opentelemetry-test-utils
  • python310Packages.opentelemetry-test-utils.dist
  • python310Packages.opentelemetry-util-http
  • python310Packages.opentelemetry-util-http.dist
  • python310Packages.strawberry-graphql
  • python310Packages.strawberry-graphql.dist
  • python311Packages.opentelemetry-api
  • python311Packages.opentelemetry-api.dist
  • python311Packages.opentelemetry-exporter-otlp
  • python311Packages.opentelemetry-exporter-otlp-proto-common
  • python311Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python311Packages.opentelemetry-exporter-otlp-proto-http
  • python311Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python311Packages.opentelemetry-exporter-otlp.dist
  • python311Packages.opentelemetry-exporter-prometheus
  • python311Packages.opentelemetry-exporter-prometheus.dist
  • python311Packages.opentelemetry-instrumentation
  • python311Packages.opentelemetry-instrumentation-asgi
  • python311Packages.opentelemetry-instrumentation-asgi.dist
  • python311Packages.opentelemetry-instrumentation-django
  • python311Packages.opentelemetry-instrumentation-django.dist
  • python311Packages.opentelemetry-instrumentation-wsgi
  • python311Packages.opentelemetry-instrumentation-wsgi.dist
  • python311Packages.opentelemetry-instrumentation.dist
  • python311Packages.opentelemetry-sdk
  • python311Packages.opentelemetry-sdk.dist
  • python311Packages.opentelemetry-test-utils
  • python311Packages.opentelemetry-test-utils.dist
  • python311Packages.opentelemetry-util-http
  • python311Packages.opentelemetry-util-http.dist
  • python311Packages.strawberry-graphql
  • python311Packages.strawberry-graphql.dist

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the changelog of importlib-metadata and the relevant parts of opentelemetry-api, and I don't think it causes any problems.

@marsam marsam merged commit ed71ea2 into NixOS:staging-next Jul 22, 2023
@tjni tjni deleted the opentelemetry-api branch July 22, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants