Conversation
|
Checked build output, seems ok. Not sure about the now dropped localstatedir flag. |
ofborg
bot
added
10.rebuild-darwin: 501+
|
The localstatedir flags seems relevant, but not sure how it's configured in meson (don't have time to check now) |
There was a problem hiding this comment.
p11_system_config_modules in pkg-config file changed $out/share/p11-kit/modules /etc/pkcs11/modules, not sure if it is an issue.
There was a problem hiding this comment.
$out/share/p11-kit/modules seems empty, I assume /etc/pkcs11/modules might be the intended path?
There was a problem hiding this comment.
The variable is reference in meson.build of gcr, but still not used else where https://github.com/GNOME/gcr/blob/c8d2e0f44bdb91b63ed04dedf7b272211dc46c6e/meson.build#L56
There was a problem hiding this comment.
There was a problem hiding this comment.
It would be passed the same way to mesonFlags but it does not look like it is used. The only reference I found with git log -G is hardcoded in https://github.com/p11-glue/p11-kit/blob/d98392beb309570c228090866d77e500bc9e30db/common/runtime.c#L51
There was a problem hiding this comment.
The p11_get_runtime_directory function and in turn the whole codebase contains no reference to localstatedir, I'm pretty sure it's unused.
ghost
mentioned this pull request
Since NixOS#244633, the installation path for p11-kit was picked up to be in the p11-kit out path, which obviously doesn't work. This commit restores the out path to the value it was before NixOS#244633.
3 participants
Description of changes
replaces #73341, fixes #244111 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)