Skip to content

Comments

librsvg: fix cross compilation by using emulator for shell completion…#244602

Merged
Artturin merged 1 commit intoNixOS:stagingfrom
NickCao:librsvg-cross
Jul 23, 2023
Merged

librsvg: fix cross compilation by using emulator for shell completion…#244602
Artturin merged 1 commit intoNixOS:stagingfrom
NickCao:librsvg-cross

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Jul 21, 2023

… generation

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • riscv64-linux (cross)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jul 21, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 21, 2023
@Artturin
Copy link
Member

Artturin commented Jul 23, 2023 •
edited
Loading

:( I don't want cross compilation work to always have to be based on staging for the next month #244950

let's merge it then periodic merge and then rebase this pr

@Artturin
Copy link
Member

Artturin commented Jul 23, 2023

oh p11-kit is broken too so much stuff will be broken anyway

@Artturin Artturin merged commit 0f9249c into NixOS:staging Jul 23, 2023
@NickCao NickCao deleted the librsvg-cross branch July 23, 2023 02:10
@jtojnar jtojnar mentioned this pull request Jul 29, 2023
Merged
12 tasks
@lilyinstarlight lilyinstarlight mentioned this pull request Jul 30, 2023
Merged
13 tasks
@yu-re-ka yu-re-ka mentioned this pull request Jul 31, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amaxine amaxine Awaiting requested review from amaxine

@dasj19 dasj19 Awaiting requested review from dasj19

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickCao @Artturin