lib/systems: revert #221707 if stdenv.hostPlatform.isPower#244436
Conversation
|
Maybe we should just keep this unconditionally and add a note about why it's important? Also, do you know why the built kernel includes the sources path at all? That sounds like a reproducibility nightmare for more conventional distros... |
The conditional fixes #224694
It's normal. The problem is that #221707 changed us from building source that was unpacked into It's pretty weird to unpack the source into
Modern conventional distros build in a sandbox just like we do, and their source is unpacked into exactly the same path within that sandbox for every build. Basically inside the sandbox, the path to the source is always |
|
This PR still doesnt fix Current best hope is #245449 |
Description of changes
#221707 broke the build on powerpc64 by creating circular outpath dependencies.
This commit fixes the breakage on powerpc by reverting it if stdenv.hostPlatform.isPower.
Closes #224694
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)