stdenvAdapters: fix condition#244403
Merged
Artturin merged 2 commits intoNixOS:masterfrom Jul 21, 2023
Merged
Conversation
11 tasks
Artturin
commented
Jul 19, 2023
sternenseemann
approved these changes
Jul 19, 2023
ghost
approved these changes
Jul 20, 2023
|
BTW ofborg-eval left for vacation this morning, hasn't been seen since. Edit: I just got a telephone call from Hydra, who's in Las Vegas right now with OfBorg; they're getting married and aren't coming back. Said they gambled away the Nix Foundation's bankroll at the blackjack tables. |
ofborg
bot
added
10.rebuild-darwin: 0
Fixes issue 244232
Comment was added in 3c36dcc and hasn't been needed because makeStaticBinaries already adds glibc.static
ghost
linked an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244403
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)