4d-minesweeper: init at 2.0

[merspieler]

Description of changes

4D Minesweeper written in Godot

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

@Janik-Haag

[Janik-Haag]

Looks good for the most part. But we might want to wait with merging a few more days since #177578 affects this and should redo the godot stuff.

[Janik-Haag]

ci fails because of trailing white spaces:

pkgs/games/4d-minesweeper/default.nix:
	67: Trailing whitespace
	73: Trailing whitespace

[Janik-Haag]

Update pkgs/games/4d-minesweeper/default.nix should be amended locally, so we can keep atomic commits.

[Janik-Haag]

nixpkgs-review fails with:

error:
       … from call site

         at /home/janik/.cache/nixpkgs-review/pr-244054/nixpkgs/pkgs/top-level/all-packages.nix:36663:21:

        36662|
        36663|   _4d-minesweeper = callPackage ../games/4d-minesweeper { };
             |                     ^
        36664|

       … while calling 'callPackageWith'

         at /home/janik/.cache/nixpkgs-review/pr-244054/nixpkgs/lib/customisation.nix:122:35:

          121|   */
          122|   callPackageWith = autoArgs: fn: args:
             |                                   ^
          123|     let

       error: evaluation aborted with the following error message: 'Function called without required argument "alsaLib" at /home/janik/.cache/nixpkgs-review/pr-244054/nixpkgs/pkgs/games/4d-minesweeper/default.nix:7, did you mean "alsa-lib"?'
https://github.com/NixOS/nixpkgs/pull/244054 failed to build

you probably have to change the alsa-lib buildInput

[Janik-Haag]

you are currently using an alias, please change that to the actual package

[Janik-Haag]

Result of nixpkgs-review pr 244054 run on x86_64-linux 1

1 package built:

• _4d-minesweeper

[Janik-Haag]

when starting the game it throws this error in my terminal:

ERROR: Condition "cache_id.size < 1" is true.
   at: _reload_cache (scene/resources/dynamic_font.cpp:908)

[Janik-Haag]

And the binary is a folder too deep:

./result/bin/4d-minesweeper/4d-minesweeper

it should be

./result/bin/4d-minesweeper

[Janik-Haag]

Mostly looks good now, but you should add a a desktop file with copyDesktopItems and makeDesktopItem.

[merspieler]

How do I do that? Just add it to nativeBuildInputs?

[Janik-Haag]

just grep for makeDesktopItem and you will find a lot of examples like pkgs/applications/science/logic/key/default.nix

[superherointj]

Eval is failing:

error: evaluation aborted with the following error message: 'Function called without required argument "godot-export-templates" at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-8/pkgs/games/4d-minesweeper/default.nix:10, did you mean "godot3-export-templates"?'

Maybe "godot-export-templates" => "godot3-export-templates"? (I haven't tested.)

[merspieler]

did the naming of godot change?

[superherointj]

did the naming of godot change?

My point was pointing out eval failed. I have not digged further. The error suggested that. But I cannot say what is the proper solution. Worth checking which Godot version upstream requires. Then feeding that specific version for both godot engine and templates.

[merspieler]

On unstable it did indeed change since we opened the pr, on 23.05 what we use it didn't. Will change and push that.

[superherointj]

Result of nixpkgs-review pr 244054 run on x86_64-linux 1

1 package failed to build:

• _4d-minesweeper

Logs: https://termbin.com/9vsi

ERROR: Condition "cache_id.size < 1" is true.
   at: _reload_cache (scene/resources/dynamic_font.cpp:908)

ERROR: Prepare Template: The given export path doesn't exist.
   at: add_message (editor/editor_export.h:254)

ERROR: Project export for preset "Linux/X11" failed.
   at: _fs_changed (editor/editor_node.cpp:818)