Skip to content

nodejs: use a response file with llvm-ar #243683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toonn merged 1 commit into from
Jul 16, 2023
Merged

nodejs: use a response file with llvm-ar #243683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkgs/development/web/nodejs/nodejs.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,14 @@ let
${if stdenv.buildPlatform.isGnu then ''
ar -cqs $libv8/lib/libv8.a @files
'' else ''
cat files | while read -r file; do
ar -cqS $libv8/lib/libv8.a $file
done
# llvm-ar supports response files, so take advantage of it if it’s available.
if [ "$(basename $(readlink -f $(command -v ar)))" = "llvm-ar" ]; then
Comment on lines +163 to +164
Copy link
Contributor

@tjni tjni Jul 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me too. I wonder though if there some way to find out whether llvm-ar is expected at eval time in nix so the block becomes:

${if stdenv.buildPlatform.isGnu || stdenv.buildPlatform.isLlvmAr} then ''
    ar -cqs $libv8/lib/libv8.a @files
'' else ''
    ...
''

Copy link
Contributor

@toonn toonn Jul 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently. We discussed in the Matrix room.

Copy link
Contributor Author

@reckenrode reckenrode Jul 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would set isLLVM, but Darwin isn’t a pure-LLVM platform. Maybe someday, but that’s still a ways off.

ar -cqs $libv8/lib/libv8.a @files
else
cat files | while read -r file; do
ar -cqS $libv8/lib/libv8.a $file
done
fi
''}
popd

Expand Down