haskell.compiler.ghc962: fix build on Darwin after stdenv rework merge#243478
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Jul 15, 2023
Merged
haskell.compiler.ghc962: fix build on Darwin after stdenv rework merge#243478vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
reckenrode
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
Contributor
Author
|
If this should target haskell-updates instead, I can retarget. I wasn’t sure since this was prompted by the failure on staging-next. |
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
|
sternenseemann
approved these changes
Jul 14, 2023
Member
sternenseemann
left a comment
sternenseemann
left a comment
There was a problem hiding this comment.
The GHC issue also describes that it only affects 9.6 and above so far, so it perfectly matches common-hadrian.nix. Haven't done a test build.
The switch to cctools-llvm made several LLVM tools the default on Darwin, which includes llvm-ar. GHC will try to use `-L` with `ar` when it is `llvm-ar`, but that doesn’t work currently on Darwin. See https://gitlab.haskell.org/ghc/ghc/-/issues/23188.
reckenrode
force-pushed
the
ghc962-hydra-fix
branch
from
10f89a5 to
6454fb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The switch to cctools-llvm made several LLVM tools the default on Darwin, which includes llvm-ar. GHC will try to use
-Lwitharwhen it isllvm-ar, but that doesn’t work currently on Darwin.See https://gitlab.haskell.org/ghc/ghc/-/issues/23188.
This is targeting staging-next because the build is currently broken. #241951
https://hydra.nixos.org/build/227354630
https://hydra.nixos.org/build/227111395
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)