Merged
Conversation
Allows us to drop a patch Also fixes systemd-repart being able to run in nix-build
github-actions
bot
added
the
6.topic: systemd
ofborg
bot
added
10.rebuild-darwin: 101-500
ElvishJerricco
approved these changes
Jul 13, 2023
Contributor
ElvishJerricco
left a comment
ElvishJerricco
left a comment
There was a problem hiding this comment.
Should we have a nixos test that verifies that systemd/systemd#27953 is fixed? Not that this should block this PR; but certainly this idea is triggered by this PR.
flokli
approved these changes
Jul 14, 2023
Member
|
Let's get this one in, if someone feels like contributing more libvirt tests, we can still do this as a followup without delaying this from going in. |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Allows us to drop a patch
Also fixes systemd-repart being able to run in nix-build
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)