darwin.stdenv: clean up portable libsystem hook#242399
Merged
wegank merged 2 commits intoNixOS:masterfrom Jul 9, 2023
Merged
Conversation
When sandboxing is enabled, the hook tries to run `install_name_tool` and fails because the system one is inaccessible. Having it use `targetPrefix` allows it to find and use the cross-install_name_tool.
12 tasks
ofborg
bot
added
10.rebuild-darwin: 0
tjni
approved these changes
Jul 9, 2023
Contributor
tjni
left a comment
tjni
left a comment
There was a problem hiding this comment.
Thanks for leaving detailed commit messages. This makes sense and looks good to me.
Contributor
Author
|
Result of 2 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I noticed this while building #242316. The hook fails to find
install_name_toolwhen sandboxing is enabled. I also cleaned up aninstall_name_toolfailure due to trying to run it on$out/binitself.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)