poetry: 1.4.2 -> 1.5.1

[Dessix]

poetry: 1.4.2 -> 1.5.1

Dropped support for python-plugin-up which has not been updated past poetry 1.4.2 after 1.5.x's significant change from tomlkit to tomli.

Based largely upon work from the hence-abandoned PR #233393.

Diff: python-poetry/poetry@refs/tags/1.4.2...1.5.1

Changelogs:
1.4.2 -> 1.5.0: python-poetry/poetry@refs/tags/1.5.0/CHANGELOG.md
1.5.0 -> 1.5.1: python-poetry/poetry@refs/tags/1.5.1/CHANGELOG.md

Dropped support for poetry-plugin-up as it has not been updated for compatibility with Poetry's new core and is apparently not taking pull requests at the moment.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[mweinelt]

poetry: 1.4.2 -> 1.5.1

All commit messages lack changelogs, as required by CONTRIBUTING.md.

poetry-core: 1.5.1 -> 1.6.1

That's too big a change for master. This is a blocker currently, hence marking it as a draft. You could use an override for the time being.

poetry-plugin-export: 1.3.1 -> 1.4.0
python310Packages.poetry-plugin-export: 1.3.1 -> 1.4.0
python311Packages.poetry-plugin-export: 1.3.1 -> 1.4.0

Every changed attribute should roughly receive its own commit. So one commit per plugin for example.

[Dessix]

Every changed attribute should roughly receive its own commit. So one commit per plugin for example.

I was avoiding this because that left multiple commits wherein each one was broken; if you'd prefer, I can indeed split them out.

poetry-core: 1.5.1 -> 1.6.1
That's too big a change for master.

They barely have support for anything less. Note that 3 months ago it was at 1.6.0, as included in @dotlambda's previous incarnation of this PR. Multiple breaking bugs and performance regressions were addressed since 1.5.1, making the version in-Nixpkgs currently dangerous to use.

[SuperSandro2000]

I was avoiding this because that left multiple commits wherein each one was broken; if you'd prefer, I can indeed split them out.

We do one commit per package update even if between the commits something is broken. Please consult the contributing guide for more details.

They barely have support for anything less. Note that 3 months ago it was at 1.6.0, as included in @dotlambda's previous incarnation of this PR. Multiple breaking bugs and performance regressions were addressed since 1.5.1, making the version in-Nixpkgs currently dangerous to use.

What hexa means is that this PR should target staging. See my standard template on how to do that.

---

This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people.

[considerate]

Looks good to me!

[SuperSandro2000]

@ofborg build poetry

[SuperSandro2000]

can you check why ofborg fails?

[Dessix]

@SuperSandro2000

can you check why ofborg fails?

Looks like #241227 may be the culprit. Hard to pick apart from how ofborg logs are structured for parallel tasks.

[mirkolenz]

Poetry 1.4.2 currently also fails to build on the unstable channel due to the linked issue #241227 with the following message:

> ERROR: Could not find a version that satisfies the requirement cachecontrol[filecache]<0.13.0,>=0.12.9 (from poetry) (from versions: none)
> ERROR: No matching distribution found for cachecontrol[filecache]<0.13.0,>=0.12.9

[domenkozar]

The following patch should fix it:

+  patches = [
+    (fetchpatch {
+      url = "https://github.com/python-poetry/poetry/pull/8055/commits/a5a6df8d8792a8ae47f1d1b57b439dee3ee4d64f.patch";
+      hash = "sha256-c2IYrdc2RaGZupRH2n26Rr2eUpDPV87Aw/P3x54j6ts=";
+    })
+  ];

[K900]

diff --git a/pkgs/tools/package-management/poetry/default.nix b/pkgs/tools/package-management/poetry/default.nix
index 48263c1f309..913b95fc8ef 100644
--- a/pkgs/tools/package-management/poetry/default.nix
+++ b/pkgs/tools/package-management/poetry/default.nix
@@ -55,12 +55,12 @@ let
           self.time-machine
         ];
       });
-      poetry-plugin-export = super.poetry-plugin-export.overridePythonAttrs(old: {
+      poetry-plugin-export = super.poetry-plugin-export.overridePythonAttrs(old: rec {
         version = "1.4.0";
         src = fetchFromGitHub {
           owner = "python-poetry";
           repo = old.pname;
-          rev = "refs/tags/${old.version}";
+          rev = "refs/tags/${version}";
           hash = "sha256-okI91Z9u5w7IHpPb9jL4Hb8+MkYJEF2qm0mqqCdyKbk=";
         };
       });

Is probably what was intended here?

[dotlambda]

poetry-plugin-export should be removed from python3Packages.

[Hamled]

The following patch should fix it:

+  patches = [
+    (fetchpatch {
+      url = "https://github.com/python-poetry/poetry/pull/8055/commits/a5a6df8d8792a8ae47f1d1b57b439dee3ee4d64f.patch";
+      hash = "sha256-c2IYrdc2RaGZupRH2n26Rr2eUpDPV87Aw/P3x54j6ts=";
+    })
+  ];

I wasn't able to get this to apply to version 1.4.2 as it was originally made for 1.5.0 I believe. I made a patch has the same changes backported to 1.4.2, but it is untested beyond building the package and running poetry init:

+  patches = [
+    (fetchpatch {
+      url = "https://github.com/Hamled/poetry/commit/d2802deec588a07626e89da33ad41bb36b885426.patch";
+      hash = "sha256-8Yznjvwz+kg4U+kml/GbodHAKYnvEn86TZfD65j/86A=";
+    })
+  ];

[dotlambda]

I updated #233393 to build poetry-plugin-up with support for poetry 1.5.

[fabaff]

Would not be needed with #242402