Skip to content

diffutils: disable hanging test on x86_64-darwin#241354

Merged
wegank merged 1 commit intoNixOS:stagingfrom
reckenrode:diffutils-darwin
Jul 4, 2023
Merged

diffutils: disable hanging test on x86_64-darwin#241354
wegank merged 1 commit intoNixOS:stagingfrom
reckenrode:diffutils-darwin

Conversation

@reckenrode
Copy link
Contributor

Description of changes

The test-c-stack tests hang on x86_64-darwin when they are run under Rosetta 2. Disabling these tests allows the rest of the tests to run successfully on that platform.

This is a similar to the issue that affected gnugrep (#236229).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The test-c-stack tests hang on x86_64-darwin when they are run under
Rosetta 2. Disabling these tests allows the rest of the tests to run
successfully on that platform.

This is a similar to the issue that affected gnugrep (NixOS#236229).
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 3, 2023
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Jul 3, 2023
@ofborg ofborg bot requested a review from dasJ July 3, 2023 22:09
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 3, 2023
@wegank
Copy link
Member

wegank commented Jul 4, 2023

Yeah, I just encountered this issue when building rustc. Thank you!

@wegank wegank merged commit cad9efb into NixOS:staging Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants