uefitoolPackages.new-engine: A62 -> A71

[athre0z]

Description of changes

This commit upgrades uefiToolPackages.new-engine to the latest version as of writing. Version A68 is now using Qt6 and no longer comes with a custom build script, so the build logic compared to the old-engine variant has become sufficiently divergent that I decided that it would be easier to split them into two entirely different derivations.

Additionally, I:

• added myself as a maintainer
• added a patch that allows the new-engine variant to build on Darwin
• correctly set mainProgram in the old-engine variant

A68 release on GitHub: https://github.com/LongSoft/UEFITool/releases/tag/A71

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux (via qemu)
  • x86_64-darwin (via rosetta)
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[ajs124]

is the old-engine variant still useful? if not, maybe we can just drop it.

[athre0z]

Theoretically the A in the version number of the new-engine variant stands for alpha, but on the other hand the old engine hasn't seen an update in 3 years. Not sure if people are still using it. It's not really much of a hassle to keep it, so I figured I'd leave it in until the devs condider the new engine to no longer be "alpha".

[jiegec]

Result of nixpkgs-review pr 240420 run on x86_64-linux 1

1 package built:

• uefitool (uefitoolPackages.new-engine)

[jiegec]

Result of nixpkgs-review pr 240420 run on aarch64-darwin 1

1 package built:

• uefitool (uefitoolPackages.new-engine)

[athre0z]

Rebased on master -- no other changes.

[athre0z]

Rebased on master and updated to A68.

[athre0z]

Rebased on master.

[lopter]

Hello,

FWIW, I did the rebase, see: 84e5df5

Procedure was to checkout old version of Nixpkgs, apply @athre0z's patch, and re-apply conflicting changes since then.

[athre0z]

Happy to rebase this if it helps. I had sort of abandoned it after it hadn't been reviewed / approved for more than a year.

[lopter]

Happy to rebase this if it helps. I had sort of abandoned it after it hadn't been reviewed / approved for more than a year.

I guess it would be nice to update the PR with the rebase I did, maybe you can get a fresh checkout of nixpkgs, apply the diff from the commit I made earlier, and update the PR?

Anyway, thank you for the work, I am trying to help with some old Thinkpad, and it needs Coreboot in order to make some hardware upgrade, and apparently uefitool is needed in the process.

[athre0z]

Thanks for providing the updated diff: did as you suggested! :)

[zimward]

whats the status of this? also in the mean time upstream released version A71

[athre0z]

Happy to update it, though at this point I don't exactly have high hopes of it being reviewed & merged. Not sure how to proceed here.

[zimward]

if the conflict gets resolved and you update it i am sure that we can get it merged in the not too soon future.

[athre0z]

Rebased and updated to A71. Let's see if we can get it merged this time.

[zimward]

A few conventions changed since you first opened the PR, after that i think it should be in a pretty good state.

[athre0z]

Thank you! I addressed all feedback. I slightly adjusted your suggested meta.mainProgram to "uefitool" since the executable name has changed in the new engine variant.

[zimward]

LGTM

[LordGrimmauld]

Have some nits.
Packages do build on x86_64-linux. Cross is broken because qt cross is a mess right now, can't really test the package itself. Building against musl and LLVM right now, but that'll take a few hours and is probably not blocking either.

[LordGrimmauld]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 240420

---

x86_64-linux

✅ 1 package built:

• uefitool (uefitoolPackages.new-engine)

[LordGrimmauld]

Diff looks good and the thing builds, though i do not feel competent judging the functionality of the actual software

[zimward]

functionality wise it looks fine. i inspected some bios images and everything looks like i would expect. (editing is sadly still not supported in NE, so not much more to test)