Skip to content

pypy3: fix sitecustomize#240187

Closed
999eagle wants to merge 1 commit intoNixOS:stagingfrom
999eagle:hotfix/pypy-env
Closed

pypy3: fix sitecustomize#240187
999eagle wants to merge 1 commit intoNixOS:stagingfrom
999eagle:hotfix/pypy-env

Conversation

@999eagle
Copy link
Contributor

Description of changes

This is a stop-gap solution for pypy3.withPackages to actually find the correct site-packages directory. This should be a workaround for #39356.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This is a stop-gap solution for pypy3.withPackages to actually find
the correct site-packages directory
@999eagle 999eagle requested a review from FRidh as a code owner June 27, 2023 20:08
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 27, 2023
@ofborg ofborg bot requested a review from andersk June 27, 2023 20:35
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 27, 2023
@FRidh
Copy link
Member

FRidh commented Jun 28, 2023

#217558 did not fix the issue entirely?

@FRidh FRidh requested a review from winterqt June 28, 2023 05:48
@SuperSandro2000
Copy link
Member

When we upgraded past this version and added Python 3.8 support 1, the sitePackages value was never updated, leading bootstrapped-pip to fail to build, because wheel was trying to be located in $out/site-packages, when it was actually installed to $out/lib/pypy3.8/site-packages.

It went into a different direction and now is searching for $out/lib/pypy3.8/lib/pypy3.8/site-packages

@SuperSandro2000
Copy link
Member

drafting because of the proper fix in #240301

@SuperSandro2000 SuperSandro2000 marked this pull request as draft June 28, 2023 08:40
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 5, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 5, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@SuperSandro2000
Copy link
Member

Fixed in #442224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants