linuxKernel.kernels.linux_rpi4,linuxKernel.kernels.linux_rpi3,linuxKernel.kernels.linux_rpi2,linuxKernel.kernels.linux_rpi1: Disable KUNIT when building the Raspberry Pi kernel#239633
Closed
ReneHollander wants to merge 1 commit intoNixOS:masterfrom
Conversation
ReneHollander
changed the title
ReneHollander
force-pushed
the
patch-2
branch
2 times, most recently
from
85849ba to
937f82a
Compare
ReneHollander
changed the title
Contributor
Author
|
@lovesegfault, can you take a look? |
ReneHollander
force-pushed
the
patch-2
branch
2 times, most recently
from
a3952f9 to
8c7a74d
Compare
ofborg
bot
requested review from
Ma27,
NeQuissimus,
TredwellGit,
alyssais and
thoughtpolice
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
See #247826 Maybe can you retarget this to nixos 23.05, since a raspberry pi kernel specific change would be welcome there (to not risk causing regressions in other kernels) |
Contributor
Author
|
Obsolete since #247826 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See comment in code for details.
This is stolen from the great work of @tstat: https://github.com/tstat/raspberry-pi-nix/blob/24f5b92db86a01f5bda2e117726f5a0e39b0ec97/overlay/default.nix#L86-L105
Sending this change to upstream it to avoid recompiling the whole Kernel on my poor Pi.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)