Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/syncthing: fix escaping #239427

Merged
merged 1 commit into from
Jun 23, 2023
Merged

nixos/syncthing: fix escaping #239427

merged 1 commit into from
Jun 23, 2023

Conversation

ncfavier
Copy link
Member

Description of changes

Fixes #239421

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ncfavier
Copy link
Member Author

ncfavier commented Jun 23, 2023 •
edited
Loading

@ofborg test syncthing syncthing-init

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 23, 2023
@ncfavier ncfavier mentioned this pull request Jun 23, 2023
Closed
@ncfavier ncfavier force-pushed the syncthing-escaping branch from 8b5daf2 to 9a9ded1 Compare June 23, 2023 18:20
@ncfavier ncfavier merged commit b7098c1 into NixOS:master Jun 23, 2023
@ncfavier ncfavier deleted the syncthing-escaping branch June 23, 2023 18:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 23, 2023
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@doronbehar doronbehar mentioned this pull request Jun 29, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syncthing: device names are not properly escaped
2 participants
@ncfavier @bjornfor