Skip to content

ttaenc: init at 3.4.1#238757

Merged
FliegendeWurst merged 2 commits intoNixOS:masterfrom
natsukagami:ttaenc-init
Dec 13, 2024
Merged

ttaenc: init at 3.4.1#238757
FliegendeWurst merged 2 commits intoNixOS:masterfrom
natsukagami:ttaenc-init

Conversation

@natsukagami
Copy link
Contributor

@natsukagami natsukagami commented Jun 20, 2023

Description of changes

ttaenc homepage: https://sourceforge.net/projects/tta/ and http://tta.tausoft.org/
build adapted from the AUR package https://aur.archlinux.org/packages/ttaenc

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukagami natsukagami force-pushed the ttaenc-init branch 2 times, most recently from 7a577a5 to 12cb7e2 Compare June 20, 2023 13:17
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 20, 2023
@piegamesde
Copy link
Member

piegamesde commented Dec 29, 2023

Please format the commit message as "maintainers: add natsukagami"

@piegamesde piegamesde removed the request for review from Janik-Haag December 29, 2023 13:45
Janik-Haag
Janik-Haag reviewed Dec 31, 2023
View reviewed changes
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me other then the two comments

@Janik-Haag
Copy link
Member

Janik-Haag commented Dec 31, 2023

oh and you should add badPlatforms = lib.platforms.darwin; or broken = stdenv.isDarwin; to meta depending on if the package has darwin support but is broken or if it is unsupported and thus a bad platform.

@piegamesde piegamesde removed their request for review December 31, 2023 13:22
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 3, 2024
@natsukagami natsukagami requested a review from Janik-Haag October 3, 2024 14:16
@natsukagami natsukagami force-pushed the ttaenc-init branch 2 times, most recently from e45118b to 171edcd Compare October 3, 2024 14:26
@Janik-Haag
Copy link
Member

Janik-Haag commented Oct 4, 2024

Hey, I left nixpkgs some time ago and thus won't be reviewing this PR anymore. #323901

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 4, 2024
@Janik-Haag Janik-Haag removed their request for review October 4, 2024 00:36
Frontear
Frontear reviewed Oct 4, 2024
View reviewed changes
pkgs/by-name/tt/ttaenc/package.nix Outdated
Copy link
Member

@Frontear Frontear Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity, is there a reason you used this here instead of just adding to the makeFlags attribute? does it operate semantically differently?

Copy link
Contributor Author

@natsukagami natsukagami Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has something to do with my CFLAGS having spaces inside. I wasn't able to figure out how to do that with makeFlags, and saw some other nixpkgs derivation doing this instead, so I copied

Frontear
Frontear reviewed Oct 4, 2024
View reviewed changes
Frontear
Frontear reviewed Oct 4, 2024
View reviewed changes
Frontear
Frontear suggested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@Frontear Frontear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main concern is the merge conflict, everything else looks good though. tested the binary using nixpkgs-review pr --checkout commit 238757 and it works.

also if you havent already, running nixfmt on this would be nice (though it already seems formatted)

@natsukagami
Copy link
Contributor Author

natsukagami commented Oct 6, 2024

Some patches introduced to make it compile on darwin, tested by a friend

FliegendeWurst
FliegendeWurst reviewed Nov 3, 2024
View reviewed changes
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 7, 2024
FliegendeWurst
FliegendeWurst reviewed Dec 7, 2024
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 8, 2024
@natsukagami natsukagami force-pushed the ttaenc-init branch 2 times, most recently from 279edef to 15eacd9 Compare December 11, 2024 17:23
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 11, 2024
FliegendeWurst
FliegendeWurst requested changes Dec 11, 2024
View reviewed changes
FliegendeWurst
FliegendeWurst reviewed Dec 11, 2024
View reviewed changes
@FliegendeWurst FliegendeWurst merged commit b8d33d0 into NixOS:master Dec 13, 2024
@natsukagami natsukagami deleted the ttaenc-init branch December 19, 2024 02:09
@natsukagami natsukagami restored the ttaenc-init branch December 19, 2024 02:09
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 19, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

+2 more reviewers

@Janik-Haag Janik-Haag Janik-Haag left review comments

@Frontear Frontear Frontear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@natsukagami @piegamesde @Janik-Haag @Frontear @FliegendeWurst @wegank