Skip to content

gow: init at 0-unstable-2025-03-28#238561

Closed
06kellyjac wants to merge 1 commit intoNixOS:masterfrom
06kellyjac:gow
Closed

gow: init at 0-unstable-2025-03-28#238561
06kellyjac wants to merge 1 commit intoNixOS:masterfrom
06kellyjac:gow

Conversation

@06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Jun 19, 2023 •
edited
Loading

Description of changes

gow init at 0-unstable-2025-03-28

The missing watch mode for go commands

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 19, 2023
nagy
nagy reviewed Aug 27, 2023
View reviewed changes
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@sivizius
Copy link
Contributor

sivizius commented Nov 10, 2024 •
edited
Loading

Obsolete by #283553 This PR was updated and #283553 was closed, so please ignore this comment of mine.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 10, 2024
@Scrumplex Scrumplex mentioned this pull request Nov 15, 2024
Closed
13 tasks
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2025
@06kellyjac 06kellyjac changed the title gow: init at unstable-2023-04-18 gow: init at 0-unstable-2025-03-28 Jun 19, 2025
@06kellyjac
Copy link
Member Author

06kellyjac commented Jun 19, 2025

Rebased and updated the package

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 19, 2025
@github-actions github-actions bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 19, 2025
@06kellyjac 06kellyjac requested review from Scrumplex and nagy June 24, 2025 12:49
nagy
nagy approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@nagy nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one unused import, otherwise lgtm.

pkgs/by-name/go/gow/package.nix
stdenv,
buildGoModule,
fetchFromGitHub,
versionCheckHook,
Copy link
Member

@nagy nagy Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this unused import?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jun 24, 2025
@wolfgangwalther wolfgangwalther mentioned this pull request Jun 24, 2025
Merged
4 tasks
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 20, 2025
@06kellyjac
Copy link
Member Author

06kellyjac commented Aug 27, 2025

closed by #434858

@06kellyjac 06kellyjac closed this Aug 27, 2025
@06kellyjac 06kellyjac deleted the gow branch August 27, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Awaiting requested review from Scrumplex

1 more reviewer

@nagy nagy nagy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@06kellyjac @sivizius @nagy @wegank