Skip to content

Comments

[23.05] cups: 2.4.2 -> 2.4.5#238068

Merged
vcunat merged 1 commit intoNixOS:staging-23.05from
onny:cups-backport
Jul 9, 2023
Merged

[23.05] cups: 2.4.2 -> 2.4.5#238068
vcunat merged 1 commit intoNixOS:staging-23.05from
onny:cups-backport

Conversation

@onny
Copy link
Contributor

@onny onny commented Jun 16, 2023 •
edited
Loading

Description of changes

See release notes for 2.4.3: https://github.com/OpenPrinting/cups/releases/tag/v2.4.3

  • Includes criticial security fix
  • Many usefull fixes which should be available on stable release
  • 2.4.4-2.4.5 only includes minor hotfixes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: printing Drivers, CUPS & Co. label Jun 16, 2023
@ofborg ofborg bot requested a review from matthewbauer June 16, 2023 10:38
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 16, 2023
@vcunat vcunat changed the base branch from release-23.05 to staging-23.05 June 17, 2023 13:40
@vcunat vcunat added 1.severity: security Issues which raise a security issue, or PRs that fix one and removed 1.severity: security Issues which raise a security issue, or PRs that fix one labels Jun 17, 2023
@vcunat
Copy link
Member

vcunat commented Jun 17, 2023

I don't see any security fix. Only including the one that was already patched.

@onny
Copy link
Contributor Author

onny commented Jun 17, 2023

I don't see any security fix. Only including the one that was already patched.

oh sorry this is what i meant :O

@fabianhjr fabianhjr added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jun 22, 2023
@fabianhjr
Copy link
Member

fabianhjr commented Jun 22, 2023

https://nvd.nist.gov/vuln/detail/CVE-2022-26691 (CVSS: 6.7)

@fabianhjr
Copy link
Member

fabianhjr commented Jun 22, 2023

Oh nvm had a brainfart, CVE-2022-26691 is up-to excluding 2.4.2, 2.4.2 is unaffected.

@fabianhjr fabianhjr removed the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jun 22, 2023
SuperSandro2000
SuperSandro2000 reviewed Jun 22, 2023
View reviewed changes
pkgs/misc/cups/default.nix
outputs = [ "out" "lib" "dev" "man" ];

patches = [
(fetchpatch {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was forgotten in the original commit to drop fetchpatch from inputs

@vcunat vcunat merged commit 7cfe8b2 into NixOS:staging-23.05 Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: printing Drivers, CUPS & Co. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@onny @vcunat @fabianhjr @SuperSandro2000