Skip to content

Comments

python311Packages.pycodestyle: Fix tests on python 3.11.4#238001

Merged
marsam merged 1 commit intoNixOS:staging-nextfrom
mweinelt:pycodestyle-test-fix
Jun 16, 2023
Merged

python311Packages.pycodestyle: Fix tests on python 3.11.4#238001
marsam merged 1 commit intoNixOS:staging-nextfrom
mweinelt:pycodestyle-test-fix

Conversation

@mweinelt
Copy link
Member

Applies a modified version of upstreams patch to fix the tests, only upstream only recognized the issue from 3.12, while it hit us on 3.11.4.

for #237233

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Applies a modified version of upstreams patch to fix the tests, only
upstream only recognized the issue from 3.12, while it hit us on 3.11.4.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 15, 2023
@ofborg ofborg bot requested a review from kamadorueda June 15, 2023 23:55
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jun 15, 2023
@marsam marsam merged commit c04ec11 into NixOS:staging-next Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants