Skip to content

python3Packages.pygame: 2.2.0 -> 2.4.0#237941

Closed
emilytrau wants to merge 1 commit intoNixOS:masterfrom
emilytrau:pygame-2.4.0
Closed

python3Packages.pygame: 2.2.0 -> 2.4.0#237941
emilytrau wants to merge 1 commit intoNixOS:masterfrom
emilytrau:pygame-2.4.0

Conversation

@emilytrau
Copy link
Member

Description of changes

Changelog 2.3.0
Changelog 2.4.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 15, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 15, 2023
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pygame 2.5.2 was released and merged in #271586. Is there any reason to keep 2.4.0?

2.5.2 on master fails to build, could you fix it if 2.4.0 is not needed?

distutils and buildconfig module not found
Traceback (most recent call last):
  File "/build/source/buildconfig/config.py", line 207, in main
    import config_unix as CFG
  File "/build/source/buildconfig/config_unix.py", line 7, in 
    from distutils.sysconfig import get_python_inc
ModuleNotFoundError: No module named 'distutils'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/build/source/buildconfig/config.py", line 247, in
main()
File "/build/source/buildconfig/config.py", line 209, in main
import buildconfig.config_unix as CFG
ModuleNotFoundError: No module named 'buildconfig'

@SuperSandro2000
Copy link
Member

Is there any reason to keep 2.4.0?

If the packages that use it, don't support 2.5. Can we all upgrade them to the newest version?

distutils and buildconfig module not found

Distutils should only be an issue for python 3.12. Can we fix the other issue?

Also can we drop the old version of SDL2_image? That would be awesome.

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve conflicts and good idea to get latest version (2.5.2).

@wegank
Copy link
Member

wegank commented Jan 22, 2024

pygame is indeed at 2.5.2 on master, however. Closing.

@wegank wegank closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants