Skip to content

Comments

elfutils: revert "split debuginfod into its own output"#237595

Merged
lheckemann merged 1 commit intoNixOS:staging-nextfrom
trofi:elfutils-no-split-debuginfod
Jun 14, 2023
Merged

elfutils: revert "split debuginfod into its own output"#237595
lheckemann merged 1 commit intoNixOS:staging-nextfrom
trofi:elfutils-no-split-debuginfod

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jun 13, 2023

This reverts commit d7ccc25.

THe change broke builds of gdb and linuxPackages_latest.systemtap.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This reverts commit d7ccc25.

THe change broke builds of `gdb` and `linuxPackages_latest.systemtap`.
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested review from edolstra and r-burns June 13, 2023 17:52
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 13, 2023
@fabianhjr fabianhjr requested a review from vcunat June 13, 2023 21:26
@lheckemann
Copy link
Member

Further digging yesterday led me to the conclusion that debuginfod should probably be its own package, not an output of elfutils. Let's get this fix in so we don't have to wait for the "proper" implementation for the packages to build again.

@lheckemann lheckemann merged commit 60e89fc into NixOS:staging-next Jun 14, 2023
@trofi trofi deleted the elfutils-no-split-debuginfod branch June 14, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants